Run integration tests against postgres 14 #34514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres.
GiteaBot
added
the
lgtm/need 2
theoludwig
reviewed
May 21, 2025
.github/workflows/pull-db-tests.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| services: | |||
| pgsql: | |||
| image: postgres:12 | |||
| image: postgres:16 | |||
There was a problem hiding this comment.
Ideally we would run both oldest and newest (13 and 17), but so far there is only one DB version, and 16 is a seemingly good "in between". But if people want 17, we can do 17 of course.
|
May 13 is better which is the minimal requirement. And we should also update the documentation about database requirements. |
I'd go straight to 14 for v1.25 given the EOL date of 13. |
I'd just change docs to require any maintained postgres version, so you don't need to babysit a minimum version in the docs each year. |
silverwind
commented
May 22, 2025
|
Changed it to 14 now. The discussion whether to use latest is not one I want to have right now. |
silverwind
changed the title
techknowlogick
approved these changes
May 22, 2025
GiteaBot
added
lgtm/need 1
lunny
approved these changes
May 22, 2025
GiteaBot
added
lgtm/done
techknowlogick
added
backport/v1.24
GiteaBot
removed
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 26, 2025
postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on. Ref: https://endoflife.date/postgresql
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 26, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Run integration tests against postgres 14 (go-gitea#34514)
techknowlogick
pushed a commit
that referenced
this pull request
May 26, 2025
Backport #34514 by @silverwind postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on. Ref: https://endoflife.date/postgresql Co-authored-by: silverwind <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postgres 12 is end of life since 6 months. 13 and above are still supported but I think it's overall better if we test a more recent version of postgres because that's what new users will be running on.
Ref: https://endoflife.date/postgresql